Fix status code in GET aliases service#1881
Conversation
Signed-off-by: Faakhir30 <zahidfaakhir@gmail.com>
|
@Faakhir30 thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
stevepiercy
left a comment
stevepiercy
left a comment
There was a problem hiding this comment.
Minor tweak to the change log to help people searching for 201 Created and wondering when it changed. Otherwise LGTM. Thank you!
Co-authored-by: Steve Piercy <web@stevepiercy.com>
|
@jenkins-plone-org please run jobs |
davisagli
left a comment
davisagli
left a comment
There was a problem hiding this comment.
@Faakhir30 @stevepiercy Thank you!
4 participants
Fixes #1862
Minor bug fix:
Aliases get service was returning
201status code on get endpoints. Updated status code to200.📚 Documentation preview 📚: https://plonerestapi--1881.org.readthedocs.build/